Make cctz::ParseDateTime() return NULL on failure#347
Merged
mkruskal-google merged 1 commit intoJul 14, 2026
Conversation
higher-performance
force-pushed
the
malformed-date-time
branch
3 times, most recently
from
July 11, 2026 03:03
ae3f739 to
0944ced
Compare
mkruskal-google
approved these changes
Jul 11, 2026
devbww
suggested changes
Jul 11, 2026
devbww
reviewed
Jul 11, 2026
|
|
||
| TEST(TimeZonePosix, ParsePosixSpec) { | ||
| PosixTimeZone zone; | ||
| EXPECT_FALSE(ParsePosixSpec("PST8PDT7", &zone)); |
Contributor
There was a problem hiding this comment.
Thanks for introducing the test.
I don't expect you do this, but, if you have the inclination, this now affords the opportunity to add a more extensive test suite.
Prevents uninitialized data from being returned when the input is malformed
higher-performance
force-pushed
the
malformed-date-time
branch
from
July 13, 2026 17:03
0944ced to
f149bfd
Compare
devbww
approved these changes
Jul 13, 2026
devbww
added a commit
to devbww/cctz
that referenced
this pull request
Jul 16, 2026
Now that google#347 has introduced `time_zone_posix_test`, expand it to cover all of `ParsePosixSpec()`, including success and failure cases. Also: - Update the BNF for `ParsePosixSpec()` after google#347 moved the comma into `datetime`. - Update the Open Group URL for the TZ environment-variable specification.
derekmauro
pushed a commit
that referenced
this pull request
Jul 17, 2026
Now that #347 has introduced `time_zone_posix_test`, expand it to cover all of `ParsePosixSpec()`, including success and failure cases. Also: - Update the BNF for `ParsePosixSpec()` after #347 moved the comma into `datetime`. - Update the Open Group URL for the TZ environment-variable specification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents uninitialized data from being returned when the input is malformed (say, when the footer is
\nPST8PDT,M3\n).